[webkit-reviews] review denied: [Bug 16809] Clicking a scrollbar blurs the currently focused element : [Attachment 54373] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 27 13:06:32 PDT 2010
Darin Adler <darin at apple.com> has denied review:
Bug 16809: Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809
Attachment 54373: patch v1
https://bugs.webkit.org/attachment.cgi?id=54373&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + // If clicking on a frame scrollbar, do not mess up with content focus.
> + if (FrameView* view = m_frame->view())
> + if (view->scrollbarAtPoint(mouseEvent.pos()))
> + return false;
Need braces around the body of this if statement.
Is an extra hit test necessary here? Is there some other way to find we clicked
on the scrollbar other than repeating the hit testing process? I'd like to see
that information passed back from the hit testing we are already doing, rather
than adding an extra check for this.
More information about the webkit-reviews
mailing list