[webkit-reviews] review denied: [Bug 38150] Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer : [Attachment 54364] v0; a small change preparing for Bug 26526

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 12:47:27 PDT 2010


Darin Adler <darin at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 38150: Refactoring: webkitEditableContentChangedEvent should be handled by
the owner of appropriate the renderer
https://bugs.webkit.org/show_bug.cgi?id=38150

Attachment 54364: v0; a small change preparing for Bug 26526
https://bugs.webkit.org/attachment.cgi?id=54364&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
WebCore/html/HTMLFormControlElement.h:160
 +	virtual void defaultEventHandler(Event*);
This should be as private as possible. I don't see any good reason to make it
public. Either protected or private should work. Similarly, I think
HTMLInputElement and HTMLTextAreaElement could now have private
defaultEventHandler functions since there is no longer anyone calling directly.


WebCore/rendering/TextControlInnerElements.cpp:119
 +	if (shadowAncestor && shadowAncestor->renderer()) {
 +	    ASSERT(shadowAncestor->renderer()->isTextControl());
We should not fetch the renderer() any more or assert that it is a text
control.

review- because I think it's worth refining this a tiny bit more, since its
entire purpose is the refactoring.


More information about the webkit-reviews mailing list