[webkit-reviews] review granted: [Bug 37203] Add layoutTestController.setPrinting() : [Attachment 54441] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 12:21:41 PDT 2010


Darin Adler <darin at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 37203: Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

Attachment 54441: Patch v3
https://bugs.webkit.org/attachment.cgi?id=54441&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  PrintContext::~PrintContext()
>  {
> -    ASSERT(!m_isPrinting);
> +    if (m_isPrinting)
> +	   end();
>      m_pageRects.clear();
>  }

Can you remove any of the explicit end() calls now?

r=me


More information about the webkit-reviews mailing list