[webkit-reviews] review denied: [Bug 38180] Remove unneeded custom code for WebSocket.send : [Attachment 54393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 11:29:35 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38180: Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Attachment 54393: Patch
https://bugs.webkit.org/attachment.cgi?id=54393&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> It seems much better to have it work the same way as every other method.

I don't have a big problem with this change in behavior per se. But I have two
problems with this patch:
1. Since it's a behavior change, there should be tests.
2. The "every other method" explanation doesn't really hold water. As I
mentioned, there are hundreds of cases where we do the same as the code you are
changing does. Those may be a minority, but not a negligible minority.


More information about the webkit-reviews mailing list