[webkit-reviews] review granted: [Bug 38197] check-webkit-style: Files should be ignored unless they have an associated checker : [Attachment 54420] Proposed patch 2

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38197: check-webkit-style: Files should be ignored unless they have an
associated checker
https://bugs.webkit.org/show_bug.cgi?id=38197

Attachment 54420: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=54420&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
The code change looks good. I'm putting r+ assuming you'll add extensions I
listed.

WebKitTools/Scripts/webkitpy/style/checker.py:674
 +		raise Exception("File should not be checked: '%s'" % file_path)

This shouldn't happen if this function isn't called from unittest, right? If
so, how about using assert statement?

WebKitTools/Scripts/webkitpy/style/checker_unittest.py:764
 +		self._processor.process(lines=['line1', 'line2'],
If you use assert statement above. We can just use assertRaises(AssertionError,
...) ?