[webkit-reviews] review granted: [Bug 33590] [GTK] GObject DOM bindings : [Attachment 54206] propertywarnings.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 10:13:48 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 33590: [GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Attachment 54206: propertywarnings.diff
https://bugs.webkit.org/attachment.cgi?id=54206&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 351 EOF
 352 push(@txtSetProps, $txtSetProps);
 353	 if (scalar @writeableProperties > 0) {
 354	     $txtSetProps = << "EOF";
306355	   ${className} *self = WEBKIT_DOM_${clsCaps}(object);
307356	   $privFunction
 357 EOF
 358 push(@txtSetProps, $txtSetProps);
 359	 }
308360 

Looks like you have some indentation problems here, except for that looks good.


More information about the webkit-reviews mailing list