[webkit-reviews] review granted: [Bug 37987] [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux) : [Attachment 54395] Add mising import

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 37987: [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and
Linux)
https://bugs.webkit.org/show_bug.cgi?id=37987

Attachment 54395: Add mising import
https://bugs.webkit.org/attachment.cgi?id=54395&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:128
 +	# FIXME: Callers should use scm.py instead.
This comment seems unrelated, but ok.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:139
 +					  shell=(sys.platform == 'win32'),
I thought we were against shell=True?

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:73
 +	    close_fds = sys.platform not in ('win32', 'cygwin')
This seems to be a repeat of the code in Executive.  Is there a way for them to
share?