[webkit-reviews] review denied: [Bug 38160] <input type="search"> with uneven padding causes text clipping : [Attachment 54381] [PATCH] Addressed Comments - Fixed Caps Lock

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Joseph Pecoraro <joepeck at webkit.org>'s request for
review:
Bug 38160: <input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

Attachment 54381: [PATCH] Addressed Comments - Fixed Caps Lock
https://bugs.webkit.org/attachment.cgi?id=54381&action=review

------- Additional Comments from mitz at webkit.org
> +	   * rendering/RenderTextControl.cpp: moved controlClipRect
implementation to TextControlSingleList

s/TextControlSingleList/RenderTextControlSingleLine/


> +	   // Center vertically like the text.
> +	   contentsRect.setY((height() - contentsRect.height()) / 2);
> +

Have you tested this with both even and odd heights?

> +IntRect RenderTextControlSingleLine::controlClipRect(int tx, int ty) const
> +{
> +    IntRect clipRect;
> +    if (!m_innerBlock)
> +	   clipRect = contentBoxRect();

Does this case ever get hit? Is it covered by the test? This looks just as
wrong as the present bug.

> +    virtual IntRect controlClipRect(int tx, int ty) const;

This should be private.

Sorry to r- again, but I don’t understand the !m_innerBlock branch of
controlClipRect().