[webkit-reviews] review granted: [Bug 38167] Add testing infrastructure for JSC bindings generator : [Attachment 54379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 26 21:42:11 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38167: Add testing infrastructure for JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38167
Attachment 54379: Patch
https://bugs.webkit.org/attachment.cgi?id=54379&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/ChangeLog:67
+ * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from
WebCore/bindings/scripts/test/V8TestObj.cpp.
It's unclear to me why these moved from v8/test to test/v8. Seems slightly
silly.
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:6
+ modify it under the terms of the GNU Library General Public
Why are we generating LGPL code? Also seems silly. But that's something to
fix later.
WebKitTools/Scripts/run-bindings-tests:46
+ # place holder for defines (generate-bindings.pl requirement)
This comment is no longer valid.
WebKitTools/Scripts/run-bindings-tests:118
+ # FIXME: Add ObjC
COM too? Or did we kill COM?
WebKitTools/Scripts/run-bindings-tests:123
+ os.path.join('WebCore', 'bindings', 'scripts', 'test'), # Input
dir
I would have put the big joins into little local vars first.
Looks OK.
More information about the webkit-reviews
mailing list