[webkit-reviews] review denied: [Bug 38160] <input type="search"> with uneven padding causes text clipping : [Attachment 54372] [PATCH] Position the clipRect where it should be

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Joseph Pecoraro <joepeck at webkit.org>'s request for
review:
Bug 38160: <input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

Attachment 54372: [PATCH] Position the clipRect where it should be
https://bugs.webkit.org/attachment.cgi?id=54372&action=review

------- Additional Comments from mitz at webkit.org
> +    RenderBox* renderer = static_cast<RenderBox*>(m_innerBlock->renderer());


0. You should use m_innerBlock->renderBox() instead of the unsafe cast.

I noticed some problems while reviewing this patch:

1. RenderTextControl’s override of hasControlClip() is redundant since it
returns false just like the base class.
2. RenderTextControl’s implementation of controlClipRect() is used only by
RenderTextControlSingleLine instances.
3. RenderTextControlSingleLine::paint() uses contentBoxRect() to paint the caps
lock indicator and is therefore similarly broken with uneven padding (the
indicator renders at the top instead of at the middle).
4. I don’t really understand the logic of
RenderTextControlSingleLine::hasControlClip(): it allows things like
      <input value="overflow" style="height: 20px; font-size: 24px;">
   which seem quite wrong.

r- since I suspect you’ll want to address item 0 and perhaps some of the
others.