[webkit-reviews] review requested: [Bug 16809] Clicking a scrollbar blurs the currently focused element : [Attachment 54373] patch v1

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 16809: Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809

Attachment 54373: patch v1
https://bugs.webkit.org/attachment.cgi?id=54373&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Summary: patch avoids clicking on frame scrollbars to cause focused elements to
blur. It matches Firefix and Opera behavior.

Details:

0) Patch only affects ports that do *not* make use of platform (native) widgets
for rendering scrollbars, including Mac, Gtk and Efl.
i.e. patches does affect ports including Qt and Chromium, where scrollbars are
handled and rendered entirely by WebCore.

1) The added layout test (scrollbar-click-does-not-blur-content.html) can not
be tested on Mac DRT because EventSendingController can only synthesize event
if it targets WebView. As on Mac scrollbars are native widgets, when they get
clicked, they process the event themselves, and do not forward to Web content.

2) The added layout test (scrollbar-click-does-not-blur-content.html) can not
be tested on Gtk DRT because in Gtk port document.body.{clientWidth,Height}
wrongly include size of scrollbars, which according to docs is wrong [1].

3) Patch does not affect in-frame scrollbars, including listbox', scrollable
<div>'s, or <textarea>'s scrollbars.

[1] https://developer.mozilla.org/en/DOM/Element.clientWidth