[webkit-reviews] review requested: [Bug 34994] Add sync bindings for Worker access to DB : [Attachment 54371] patch #1: stubs for storage classes

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 34994: Add sync bindings for Worker access to DB
https://bugs.webkit.org/show_bug.cgi?id=34994

Attachment 54371: patch #1: stubs for storage classes
https://bugs.webkit.org/attachment.cgi?id=54371&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
After talking to Michael and Eric about this, we decided that it would be best
have a single-threaded sync API implementation (everything's done on the
worker's context thread). So I made small changes to the patch to account for
that.

In case you wonder why we don't want to use the DB thread:
-- no benefit: the main thread cannot do anything while the task is processed
on the DB thread.
-- simpler code: no locks, thread-safe classes, tasks, thread switching, etc.
-- faster: no need to wait for the DB thread to run the async DB tasks that are
in the queue before getting to the sync task.
-- fewer changes to the existing code: no need to modify DatabaseThread, for
example, to support both types of databases.