[webkit-reviews] review granted: [Bug 37987] [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux) : [Attachment 54251] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 37987: [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and
Linux)
https://bugs.webkit.org/show_bug.cgi?id=37987

Attachment 54251: Patch
https://bugs.webkit.org/attachment.cgi?id=54251&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  The comments below are minor.

WebKitTools/Scripts/webkitpy/layout_tests/driver_test.py:62
 +	driver.stop()
To we need a finally to make sure we run this line of code?

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:569
 +		    wdiff = wdiff.replace('##WDIFF_DEL##', '<span class=del>')
Yuck

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:735
 +	    browser_wrapper = os.environ.get("BROWSER_WRAPPER", None)
I think this "None" is superfluous.

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:740
 +		_log.error("BROWSER_WRAPPER will be removed any time after June
1st 2010 and your scripts will break.")
Yay.  Environment variables are evil.