[webkit-reviews] review denied: [Bug 37905] Rendering SVGs through img elements is slow : [Attachment 53915] Updated patch with coding style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 26 15:59:24 PDT 2010


Eric Seidel <eric at webkit.org> has denied Simon Hausmann <hausmann at webkit.org>'s
request for review:
Bug 37905: Rendering SVGs through img elements is slow
https://bugs.webkit.org/show_bug.cgi?id=37905

Attachment 53915: Updated patch with coding style fixes
https://bugs.webkit.org/attachment.cgi?id=53915&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Woh:
 246	 // Don't delete the frame cache right away as someone might still hold

 247	 // a pointer to the NativeImagePtr returned by
nativeImageForCurrentFrame.
 248	 m_frameCacheDirty = true;
That sounds really complicated and scary.

This is what ref counting was invented to solve.  Not understanding when things
get deleted is badnews bears.


More information about the webkit-reviews mailing list