[webkit-reviews] review denied: [Bug 38128] Don't add empty credential to CredentialStorage. : [Attachment 54318] change the ChangeLog as per Davin's comment.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 38128: Don't add empty credential to CredentialStorage.
https://bugs.webkit.org/show_bug.cgi?id=38128

Attachment 54318: change the ChangeLog as per Davin's comment.
https://bugs.webkit.org/attachment.cgi?id=54318&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch only modifies one code path, avoiding badness in
CredentialStorage::set() on some platforms. I think that it would be better for
consistency to add an early return regardless of OS X version, something like 

    if (credential.isEmpty()) {
	clearAuthentication();
	return;
    }

 +	    No new tests added because it doesn't change the current behavior.

I think that that a more accurate explanation would be "because this only
affects credentials entered by the user, and we cannot test authentication
dialog in DumpRenderTree".

We need to make the same changes on Windows, but that can be a separate patch
that someone (possibly myself) can make later.