[webkit-reviews] review denied: [Bug 38048] Move _path_to_apache_config_file down to webkit.py : [Attachment 54278] Move _path_to_apache_config_file down to webkit.py

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Tor Arne Vestbø <vestbo at webkit.org>'s
request for review:
Bug 38048: Move _path_to_apache_config_file down to webkit.py
https://bugs.webkit.org/show_bug.cgi?id=38048

Attachment 54278: Move _path_to_apache_config_file down to webkit.py
https://bugs.webkit.org/attachment.cgi?id=54278&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This will break Chromium, since it does not inherit from webkit.py

Seems this should be a white-list for debian instead of a blacklist:
+	     distro =
platform.linux_distribution(full_distribution_name=False)[0]
+	     # FIXME: This is not going to scale. We should find a better way
to choose
+	     # which config file to use, while still supporting the major
distributions
+	     if distro in ["SuSE", "fedora", "redhat", "centos", "mandrake",
+			   "mandriva", "rocks", "slackware", "yellowdog",
"turbolinux"]:

Also, seems like we need a platform abstraction instead of a port in this case.