[webkit-reviews] review denied: [Bug 38127] MediaTokenizer::writeRawData() shouldn't call finish() : [Attachment 54305] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 26 09:35:11 PDT 2010


Darin Adler <darin at apple.com> has denied Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 38127: MediaTokenizer::writeRawData() shouldn't call finish()
https://bugs.webkit.org/show_bug.cgi?id=38127

Attachment 54305: the patch
https://bugs.webkit.org/attachment.cgi?id=54305&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Which regression test triggers the assertion failure? If there is no regression
test that triggers it, then we should write one. Or we need to explain why it's
not possible to write on in the change log.

We do not accept patches to fix bugs without regression tests. If there is some
reason a regression test cannot be created, then feel free to add a comment
explaining that and put it back up for review.


More information about the webkit-reviews mailing list