[webkit-reviews] review granted: [Bug 37066] check-webkit-style: Separate the file-reading code from the rest of the style-checking code : [Attachment 54275] Proposed patch 2

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 37066: check-webkit-style: Separate the file-reading code from the rest of
the style-checking code
https://bugs.webkit.org/show_bug.cgi?id=37066

Attachment 54275: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=54275&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> It's funny you ask.  I originally didn't have it, but pep8.py flagged it.  I
> agree it doesn't look right.	Maybe I can add a comment so the reader of the
> code knows why it is there.

Hmm. So, let's leave the blank line. I'm not sure if we need the comment. If we
put this comment here, we should put the same comment whenever we will write
similar code.

Or, maybe we can just create StyleProcessor.increment_error_count().

Anyway, please choose the way as you like.