[webkit-reviews] review requested: [Bug 37066] check-webkit-style: Split the StyleChecker class into a generalized FileProcessor class and a StyleProcessor : [Attachment 54244] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 25 15:49:24 PDT 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 37066: check-webkit-style: Split the StyleChecker class into a generalized
FileProcessor class and a StyleProcessor
https://bugs.webkit.org/show_bug.cgi?id=37066

Attachment 54244: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=54244&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
To make the review easier, I am doing the deletions of the old classes in a
separate patch.

Note also that because this patch eliminates the StyleChecker class, in this
patch I am updating the TextFileReader class to use the file-existence check
logic discussed and implemented in this patch:

https://bugs.webkit.org/show_bug.cgi?id=37122


More information about the webkit-reviews mailing list