[webkit-reviews] review requested: [Bug 38091] Build error without geolocation : [Attachment 54237] Fixing build break when Geolocation feature is disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 25 06:04:02 PDT 2010


Ryuan Choi <bunhere at gmail.com> has asked  for review:
Bug 38091: Build error without geolocation
https://bugs.webkit.org/show_bug.cgi?id=38091

Attachment 54237: Fixing build break when Geolocation feature is disabled
https://bugs.webkit.org/attachment.cgi?id=54237&action=review

------- Additional Comments from Ryuan Choi <bunhere at gmail.com>
Can I fix this build break?
I am newbie in webkit.org

My modification is as below,

Index: WebCore/page/Geolocation.cpp
===================================================================
--- WebCore/page/Geolocation.cpp	(revision 58227)
+++ WebCore/page/Geolocation.cpp	(working copy)
@@ -659,6 +659,8 @@ void Geolocation::stopUpdating()

 namespace WebCore {

+void Geolocation::clearWatch(int watchId) {}
+

I think clearWatch() should be added to #else of ENABLE(GEOLOCATION) in
Geolocation.cpp

Thank you,
Ryuan Choi


More information about the webkit-reviews mailing list