[webkit-reviews] review requested: [Bug 24529] Add support in Web Inspector for examining/changing data for HTML5 offline-Web-applications (application cache) : [Attachment 54234] [PATCH] WebCore Messages -> Frontend (Includes New Files)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 25 03:03:23 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 24529: Add support in Web Inspector for examining/changing data for HTML5
offline-Web-applications (application cache)
https://bugs.webkit.org/show_bug.cgi?id=24529

Attachment 54234: [PATCH] WebCore Messages -> Frontend (Includes New Files)
https://bugs.webkit.org/attachment.cgi?id=54234&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This is a good start. Nothing very complex, but I can break this down to 2
patches if desired.

In this patch:
An InspectorApplicationCacheAgent is owned by the InspectorController and is
accessible from the InspectorController with a convenience method on the Page
(like InspectorTimelineAgent). Right now it receives some messages from WebCore
that are sent to the front end. The messages are very simple status updates
right now. Such as the applicationCache.status changes and navigator.onLine
changes (online / offline events). It also allows for special handling of the
manifest file. No special handling as of part 1.

Notes for reviewers:
I've attached pictures of the UI for this part of the patch. There are FIXMEs
in JavaScript UI code describing all places that may need to undergo a change /
discussion. Also, attachment #1 is the only possible UI after part 1. The
front-end does not yet fetch resources to populate the table. However, I did
attach an image of what items would look like with the state of this patch.
Also, make sure I'm using OwnPtr correctly (no leaks). I have yet to find the
"best" place to put initialization of the InspectorApplicationCacheAgent, but
it should probably be done lazily, only if the page needs it or not.


More information about the webkit-reviews mailing list