[webkit-reviews] review granted: [Bug 37304] WebKit does not support jpeg qulaity in canvas.toDataURL : [Attachment 53408] Fixed build issue for mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 24 12:50:22 PDT 2010


Sam Weinig <sam at webkit.org> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 37304: WebKit does not support jpeg qulaity in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=37304

Attachment 53408: Fixed build issue for mac
https://bugs.webkit.org/attachment.cgi?id=53408&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
This looks good and I would like to get this landed.  My one suggestion would
be to put the test in platform independent location (if possible) and just skip
it on platforms where this is not implemented (and file bugs for those
platforms to implement the feature). You may also want to test that the quality
argument does not effect non-jpep MIME types (if possible).

r=me.


More information about the webkit-reviews mailing list