[webkit-reviews] review granted: [Bug 38027] check-webkit-style complains about non-utf8 data in layout test result : [Attachment 54210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 20:15:54 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 38027: check-webkit-style complains about non-utf8 data in layout test
result
https://bugs.webkit.org/show_bug.cgi?id=38027

Attachment 54210: Patch
https://bugs.webkit.org/attachment.cgi?id=54210&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:503
 +	    # as we're passing --name-status which does not output any data.
This comment seems gratuitously different than the others.  Also, technically,
file names (on unix) might not be UTF8 because they are just bytes.  I don't
think we should worry about that here though.  Just more background for the
trail of tears.

Nice!


More information about the webkit-reviews mailing list