[webkit-reviews] review granted: [Bug 38031] [chromium] WebKitTools\Scripts\webkitpy\layout_tests\port\http_server.py causes a syntax error for Vista, XP, Nacl : [Attachment 54141] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 38031: [chromium]
WebKitTools\Scripts\webkitpy\layout_tests\port\http_server.py causes a syntax
error for Vista, XP, Nacl
https://bugs.webkit.org/show_bug.cgi?id=38031

Attachment 54141: Patch
https://bugs.webkit.org/attachment.cgi?id=54141&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/ChangeLog:5
 +	    remove 'with' from files run on chromium buildbots
Please explain why we're making this change.

WebKitTools/Scripts/webkitpy/common/system/executive.py: 
 +	    stderr = subprocess.STDOUT if return_stderr else None
Please add a FIXME to explain that we should put this back once we can actually
use python 2.5.

This change is extremely fragile.  I have no idea which files need 2.4 support
and which don't, which means we're going to be constantly breaking this
property in the future.  We need to update the Chromium bots to a supported
version of Python or we're going to continue to feel this pain going forward.