[webkit-reviews] review granted: [Bug 37722] Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue : [Attachment 54161] Proper check
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 23 09:09:55 PDT 2010
Darin Adler <darin at apple.com> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 37722: Allow to construct
HashTraits<WebCore::QualifiedName>::constructDeletedValue
https://bugs.webkit.org/show_bug.cgi?id=37722
Attachment 54161: Proper check
https://bugs.webkit.org/attachment.cgi?id=54161&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + ASSERT(!isHashTableDeletedValue()); // HashTableDeletedValue values must
be never derefed..
There's an extra period here. Also, the comment says the same thing as the
assertion, so I suggest just leaving the comment out.
I'm going to say r=me, but I am wondering how you tested this change, given the
old wrong version you had here before.
More information about the webkit-reviews
mailing list