[webkit-reviews] review denied: [Bug 37983] Add RVCT support for Linux : [Attachment 54053] Add RVCT support for Linux v2

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 37983: Add RVCT support for Linux
https://bugs.webkit.org/show_bug.cgi?id=37983

Attachment 54053: Add RVCT support for Linux v2
https://bugs.webkit.org/attachment.cgi?id=54053&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Looks good to me, except one merge conflict that needs to be addressed.

> diff --git a/JavaScriptCore/wtf/MathExtras.h
b/JavaScriptCore/wtf/MathExtras.h
> index a0c7466..2bf2dd3 100644
> --- a/JavaScriptCore/wtf/MathExtras.h
> +++ b/JavaScriptCore/wtf/MathExtras.h
> @@ -188,7 +188,7 @@ inline float deg2turn(float d) { return d / 360.0f; }
>  inline float rad2grad(float r) { return r * 200.0f / piFloat; }
>  inline float grad2rad(float g) { return g * piFloat / 200.0f; }
>  
> -#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(ANDROID) && !COMPILER(WINSCW)
> +#if !COMPILER(MSVC) && !OS(ANDROID) && !COMPILER(WINSCW) && !(COMPILER(RVCT)
&& OS(SYMBIAN))
>  using std::isfinite;
>  using std::isinf;
>  using std::isnan;

!OS(ANDROID) test has been removed - see
http://trac.webkit.org/changeset/58142.

r-, just to make this small change.