[webkit-reviews] review granted: [Bug 36394] Include git commits in the diff for webkit-patch upload/land. : [Attachment 53904] Patch-10001

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 36394: Include git commits in the diff for webkit-patch upload/land.
https://bugs.webkit.org/show_bug.cgi?id=36394

Attachment 53904: Patch-10001
https://bugs.webkit.org/attachment.cgi?id=53904&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:181
 +	def changed_files(self, git_commit=None, squash=None):
Should this be squash=False?

WebKitTools/Scripts/webkitpy/common/checkout/api.py:131
 +		raise ScriptError(message="Working directory must be clean to
revert a revision.")
Why did you add this error handling here?  This is the wrong layer to catch
this error.  Notice that apply patch doesn't have a similar check even though
it has logically the same issue.

Thanks for sticking with this patch.  I didn't understand the gut part, but I
appreciate the tests and the effort you put into it.  Eric should review this
change, but he's been slacking off in this department.