[webkit-reviews] review granted: [Bug 37998] Improve code generator scripts to handle OR ('|') condition in the extended attributes : [Attachment 54079] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 23 00:47:48 PDT 2010
Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 37998: Improve code generator scripts to handle OR ('|') condition in the
extended attributes
https://bugs.webkit.org/show_bug.cgi?id=37998
Attachment 54079: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=54079&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/scripts/CodeGeneratorJS.pm:298
+ } else {
Maybe it's better to be explicit here? You're assuming that not & is |
Nice removal Of copy/paste code. Please address the above before landing.
More information about the webkit-reviews
mailing list