[webkit-reviews] review granted: [Bug 38030] Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds : [Attachment 54127] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 38030: Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on
debug builds
https://bugs.webkit.org/show_bug.cgi?id=38030

Attachment 54127: Patch
https://bugs.webkit.org/attachment.cgi?id=54127&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
WebCore/platform/text/TextEncodingRegistry.cpp:332
 +		sleep(1); // Avoid asl log throttling.
This will be unhelpful when dumping to terminal, as it happens with run-safari
or when debugging in gdb.

WebCore/ChangeLog:3
 +	    Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on
debug builds
Please add bug URL to ChangeLog.