[webkit-reviews] review denied: [Bug 37722] Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue : [Attachment 53702] Proper is deleted check
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 22 17:41:45 PDT 2010
Darin Adler <darin at apple.com> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 37722: Allow to construct
HashTraits<WebCore::QualifiedName>::constructDeletedValue
https://bugs.webkit.org/show_bug.cgi?id=37722
Attachment 53702: Proper is deleted check
https://bugs.webkit.org/attachment.cgi?id=53702&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
WebCore/dom/QualifiedName.h:62
+ bool isHashTableDeletedValue() const { return !m_impl; }
This can't be right. It should be:
bool isHashTableDeletedValue() { return m_impl == hashTableDeletedValue();
}
Right?
More information about the webkit-reviews
mailing list