[webkit-reviews] review denied: [Bug 37163] [Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates. : [Attachment 54078] Fix applied to QWebPage. Tests added for QGraphicsWebView and QWebView

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied John Pavan
<john.pavan at nokia.com>'s request for review:
Bug 37163: [Qt] inputMethodQuery returns coordinates in web page coordinates
rather than in item coordinates.
https://bugs.webkit.org/show_bug.cgi?id=37163

Attachment 54078: Fix applied to QWebPage.  Tests added for QGraphicsWebView
and QWebView
https://bugs.webkit.org/attachment.cgi?id=54078&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
WebKit/qt/tests/qwebview/tst_qwebview.cpp:227
 +  
This qWait does not seems to be needed, and will slow down running the
automated tests.

WebKit/qt/ChangeLog:7
 +	    
We need a reference here (link) to the bugzilla bugreport - this is
automatically generated if you use the prepare-ChangeLog script.



Overall the patch looks great, I would give an r+ if you would be a committer.
Let's fix this 2 small issues in a new patch.