[webkit-reviews] review requested: [Bug 37719] Some HTML5 Input tags not treated as needing an input method. : [Attachment 54097] Patch shouldUseInputMethod() to use isTextField & inputType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 14:33:50 PDT 2010


Ray <Raymond.Rischpater at Nokia.com> has asked  for review:
Bug 37719: Some HTML5 Input tags not treated as needing an input method.
https://bugs.webkit.org/show_bug.cgi?id=37719

Attachment 54097: Patch shouldUseInputMethod() to use isTextField & inputType
https://bugs.webkit.org/attachment.cgi?id=54097&action=review

------- Additional Comments from Ray <Raymond.Rischpater at Nokia.com>
Changed to include comment & use isTextField() && inputType() to determine
result instead of hard-coded comparisons. shouldUseInputMethod now returns true
if the field in question is a text field (as determined by isTextField) that is
editable and not a password field, as previously suggested.


More information about the webkit-reviews mailing list