[webkit-reviews] review granted: [Bug 37731] Integrate v8 testing utility with webkit tests : [Attachment 53687] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Yaar Schnitman <yaar at chromium.org>'s
request for review:
Bug 37731: Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731

Attachment 53687: Patch
https://bugs.webkit.org/attachment.cgi?id=53687&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for the patch!  Glad to have this testing harness.  :)

WebKitTools/Scripts/run-bindings-tests:105
 +	overwrite = "--overwrite" in argv
We should probably use option parser here instead of doing this manually.

WebKitTools/Scripts/run-bindings-tests:82
 +		workDir = tempfile.mkdtemp()
I still think we should do this in memory, but ok.