[webkit-reviews] review granted: [Bug 37973] REGRESSION(58040): TextIterator may use freed memory : [Attachment 54028] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 22 12:56:04 PDT 2010
Darin Adler <darin at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 37973: REGRESSION(58040): TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
Attachment 54028: Patch v1
https://bugs.webkit.org/attachment.cgi?id=54028&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
WebCore/editing/TextIterator.h:130
+ // Prevent m_textCharacters from being freed.
+ String m_text;
I think this comment is not as clear as it could be, but I don't have any
specific suggestions for improving it.
More information about the webkit-reviews
mailing list