[webkit-reviews] review denied: [Bug 37845] [chromium] new-run-webkit-tests --use-drt should run on Linux : [Attachment 53788] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 12:51:16 PDT 2010


Adam Barth <abarth at webkit.org> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 37845: [chromium] new-run-webkit-tests --use-drt should run on Linux
https://bugs.webkit.org/show_bug.cgi?id=37845

Attachment 53788: Patch
https://bugs.webkit.org/attachment.cgi?id=53788&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:91
 +	def results_directory(self):
Why is this code copy/pasted twice?  It seems better to have it in the base
class if its used by more than one subclass.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:167
 +	def _path_to_image_diff(self):
This code looks copy/pasted too.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py:101
 +	def results_directory(self):
Here the code is again.  We don't want any copy/paste code.


More information about the webkit-reviews mailing list