[webkit-reviews] review granted: [Bug 37913] MD5 is required for WebSocket new protocol implementation : [Attachment 54026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 12:43:22 PDT 2010


Adam Barth <abarth at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 37913: MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913

Attachment 54026: Patch
https://bugs.webkit.org/attachment.cgi?id=54026&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
JavaScriptCore/wtf/MD5.cpp:74
 +	  snprintf(buf, 3, "%02x", digest.at(i));
Why the mix of two space and four space indent?

JavaScriptCore/wtf/MD5.h:31
 +  #ifndef MD5_h
I thought we had a WTF in the header guards in WTF.


More information about the webkit-reviews mailing list