[webkit-reviews] review granted: [Bug 37840] Add FileError for File API : [Attachment 54080] Proposed Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 37840: Add FileError for File API
https://bugs.webkit.org/show_bug.cgi?id=37840

Attachment 54080: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=54080&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
r=me with 2 nits:

diff --git a/WebCore/dom/ExceptionCode.h b/WebCore/dom/ExceptionCode.h
+
+	 // Introduced in File API:

It'd be nice to have a link to a spec here as well.

+#if ENABLE(FILE_READER) || ENABLE(FILE_WRITER)
+	 NOT_READABLE_ERR = 24,
+	 ENCODING_ERR = 26,
+#endif

diff --git a/WebCore/html/FileError.h b/WebCore/html/FileError.h
+private:
+    FileError() : m_code(0) { }

Initializer should be on a separate line.