[webkit-reviews] review requested: [Bug 37554] REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot : [Attachment 54081] Added check in ScheduledAction

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 11:40:04 PDT 2010


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 37554: REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard
Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554

Attachment 54081: Added check in ScheduledAction
https://bugs.webkit.org/attachment.cgi?id=54081&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I've added a check in Scheduled action, it makes sense to have this checks in
all places that may be in worker's code .

I'm still feeling the check for the global object wrapper performed down the
hierarchy is the right thing. For example, dispatchEvent() invokes a
non-virtual fireEventListeners which has a loop over all registered event
handler functions and invoke them one after another. If the execution was
terminated in the middle of one, we want to avoid invoking the rest.


More information about the webkit-reviews mailing list