[webkit-reviews] review denied: [Bug 37997] [EFL] Update EWebKit to match recent API changes : [Attachment 54074] Update ewk to match recent API changes

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 37997: [EFL] Update EWebKit to match recent API changes
https://bugs.webkit.org/show_bug.cgi?id=37997

Attachment 54074: Update ewk to match recent API changes
https://bugs.webkit.org/attachment.cgi?id=54074&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 1845 #if 0
18361846     WTF::RefPtr<WebCore::PluginView> pluginView =
WebCore::PluginView::create
18371847	 (sd->frame, pluginSize, element, url, paramNames, paramValues,

18381848	  mimeType, loadManually);
18391849 
18401850     if (pluginView->status() ==
WebCore::PluginStatusLoadedSuccessfully)
18411851	 return pluginView;
 1852 #endif
18421853 

It's not usual to have code ifdefed/commented out in WebKit, and it looks like
this change should go separately?

991 	 sd->frame->setZoomFactor(zoom, sd->zoom_text_only);
 991	 WebCore::ZoomMode zoomMode;
 992	 if (sd->zoom_text_only)
 993	     zoomMode = WebCore::ZoomTextOnly;
 994	 else
 995	     zoomMode = WebCore::ZoomPage;
 996	 sd->frame->setZoomFactor(zoom, zoomMode);

Just to be clear, this was WebCore going from boolean to an enum?

r- because of the first issue