[webkit-reviews] review granted: [Bug 37991] Do not pause movie when readyState drops below HAVE_FUTURE_DATA : [Attachment 54066] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 37991: Do not pause movie when readyState drops below HAVE_FUTURE_DATA
https://bugs.webkit.org/show_bug.cgi?id=37991

Attachment 54066: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=54066&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

>  bool HTMLMediaElement::potentiallyPlaying() const
>  {
> -    return m_readyState >= HAVE_FUTURE_DATA && couldPlayIfEnoughData();
> +    bool pausedToBuffer = m_readyStateMaximum >= HAVE_FUTURE_DATA &&
m_readyState < HAVE_FUTURE_DATA;
> +    return (pausedToBuffer || m_readyState >= HAVE_FUTURE_DATA) &&
couldPlayIfEnoughData();

I think a comment here would be useful, to explain exactly what pausedToBuffer
means.