[webkit-reviews] review canceled: [Bug 37779] [GTK] Button and Entry font color doesn't respect the system's style : [Attachment 53664] A preliminary patch

[bugzilla-daemon at webkit.org]

Olivier Tilloy <olivier at tilloy.net> has canceled Olivier Tilloy
<olivier at tilloy.net>'s request for review:
Bug 37779: [GTK] Button and Entry font color doesn't respect the system's style
https://bugs.webkit.org/show_bug.cgi?id=37779

Attachment 53664: A preliminary patch
https://bugs.webkit.org/attachment.cgi?id=53664&action=review

------- Additional Comments from Olivier Tilloy <olivier at tilloy.net>
This is an updated patch that fixes the issue for all input widgets.
Please note that it predictably breaks the following layouts tests which will
need to be adapted or skipped:

  editing/selection/select-box.html
  fast/css/text-input-with-webkit-border-radius.html
  fast/forms/button-style-color.html

Known limitation: when the theme is changed on the fly, the text of the input
widgets is not re-rendered, so the font color is wrong. This is not a
regression though, it was already the case. Either the functionality to trigger
a re-rendering is missing in webkit itself, or I couldn't locate it. For
comparison, firefox does re-render.

Comments welcome!