[webkit-reviews] review requested: [Bug 37323] [Qt] tst_QWebHistoryInterface::visitedLinks() fails : [Attachment 54060] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 08:43:37 PDT 2010


yi shen <yi.4.shen at nokia.com> has asked  for review:
Bug 37323: [Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Attachment 54060: proposed patch
https://bugs.webkit.org/attachment.cgi?id=54060&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
Fix the tst_QWebHistoryInterface::visitedLinks by using
DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo to get the correct
info.
I have run the test on my local many many times and I am sure
DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo won't cause any
crash.
Please take a look at the comments of
https://bugs.webkit.org/show_bug.cgi?id=37759. Thanks a lot!


More information about the webkit-reviews mailing list