[webkit-reviews] review denied: [Bug 37848] WCSS: -wap-input-format and -wap-input-required not supported. : [Attachment 53930] resubmit of the patch after addressing reviewer's comments

[bugzilla-daemon at webkit.org]

George Staikos <staikos at kde.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 37848: WCSS: -wap-input-format  and -wap-input-required not supported.
https://bugs.webkit.org/show_bug.cgi?id=37848

Attachment 53930: resubmit of the patch after addressing reviewer's comments
https://bugs.webkit.org/attachment.cgi?id=53930&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +#if ENABLE(WCSS)
> +void HTMLInputElement::setWapInputFormat(String& mask)
> +{
> +    String validateMask = validateInputMask(m_data, mask);
> +    if (!validateMask.isEmpty())
> +	   m_data.setInputFormatMask(validateMask);
> +}
> +#endif

I think the argument to this function should be const.

> +    virtual InputElementData data() { return m_data; }

 These functions should probably be const?



The rest looks good.  r- for those two minor fixes, then r+ if no concerns from
others between now and morning.