[webkit-reviews] review requested: [Bug 16131] ZWNJ - Display non-printing, invisible character : [Attachment 54015] [PATCH] Updated Test with Greater Pixel Test Difference

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 21 19:33:15 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 16131: ZWNJ - Display non-printing, invisible character
https://bugs.webkit.org/show_bug.cgi?id=16131

Attachment 54015: [PATCH] Updated Test with Greater Pixel Test Difference
https://bugs.webkit.org/attachment.cgi?id=54015&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Dan Bernstein pointed out to me that the diff in the pixel test might not be
enough. This was my first time with pixel tests and I didn't know there was a
tolerance! Indeed the last patch's test doesn't have more than 0.1% difference.
I've got an updated test has 0.32%. This test mostly has larger fonts, and it
removed the textarea from the tests, since I could not determine what that was
testing before.

Sorry about the extra email, and I'll be more careful with pixel tests next
time.


More information about the webkit-reviews mailing list