[webkit-reviews] review granted: [Bug 37952] Create a template for reference-counted Windows GDI handles. : [Attachment 54003] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 37952: Create a template for reference-counted Windows GDI handles.
https://bugs.webkit.org/show_bug.cgi?id=37952

Attachment 54003: patch
https://bugs.webkit.org/attachment.cgi?id=54003&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is OK as is, but there is one thing we should improve. The hash function
here should be:

    return PtrHash<T>(m_handle);

Once you change it to work that way you can remove the include of StringImpl.h.


If this wasn't all inlined, I would also suggest making a base class, since the
only functions in RefCountedGDIHandle that are different based on type are the
create() function, the constructor, and the handle() function. But since
everything is inlined anyway, I don't think there's any real benefit to doing
so.