[webkit-reviews] review denied: [Bug 37837] [chromium] Select popups should be closed when the browser window is moved/resized. : [Attachment 53758] Make a unique method to close all popups.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 37837: [chromium] Select popups should be closed when the browser window is
moved/resized.
https://bugs.webkit.org/show_bug.cgi?id=37837

Attachment 53758: Make a unique method to close all popups.
https://bugs.webkit.org/attachment.cgi?id=53758&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebView.h

> -    // DEPRECATED: WebView::hideSuggestionsPopup is the new way to access
this.
> -    virtual void hideAutofillPopup() = 0;
> -
> -    // Hides the suggestions popup if any are showing.
> -    virtual void hideSuggestionsPopup() = 0;
> +    // Hides any popup (suggestions, selects...) that might be showing.
> +    virtual void hidePopups() = 0;


Won't this break Chromium when it is committed?  Can you preserve the old
method(s) until Chromium is switched over to only calling hidePopups?  Then
circle back with a cleanup patch to remove the DEPRECATED methods.

Otherwise, LGTM