[webkit-reviews] review granted: [Bug 37900] cloneNode() does not preserve z-index with more than six digits : [Attachment 53977] Minimal workaround for number formatting problem of large integral values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 21 13:05:57 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Steven Lai
<s3lance at hotmail.com>'s request for review:
Bug 37900: cloneNode() does not preserve z-index with more than six digits
https://bugs.webkit.org/show_bug.cgi?id=37900

Attachment 53977: Minimal workaround for number formatting problem of large
integral values
https://bugs.webkit.org/attachment.cgi?id=53977&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This test needn't use waitUntilDone/notifyDone.

+LOG(newEl.style.zIndex + " " + (newEl.style.zIndex == 20002000 ? "PASS" :
"FAIL"));

It's often helpful to dump the failing value (e.g. "FAIL: 2.0002e+7") - that
way, if the test starts failing on some buildbots, there will be more data for
investigation. Not too important - I don't think platform specific failures are
likely on this test.

r=me


More information about the webkit-reviews mailing list