[webkit-reviews] review denied: [Bug 37902] REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test. : [Attachment 53962] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 21 09:26:44 PDT 2010
Darin Adler <darin at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 37902: REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the
acid3 test.
https://bugs.webkit.org/show_bug.cgi?id=37902
Attachment 53962: Patch
https://bugs.webkit.org/attachment.cgi?id=53962&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
The correct fix is not to make the bitfield larger. Instead we type the
bitfield "unsigned" and add a comment with the type:
unsigned _insideLink : 2; // EInsideLink
See the line above.
We might be able to change check-webkit-style to catch this.
More information about the webkit-reviews
mailing list