[webkit-reviews] review denied: [Bug 25648] When the video controls are updated the whole video is redisplayed (RenderSlider repaint). : [Attachment 50244] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 21 07:50:05 PDT 2010


Dave Hyatt <hyatt at apple.com> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 25648: When the video controls are updated the whole video is  redisplayed
(RenderSlider repaint).
https://bugs.webkit.org/show_bug.cgi?id=25648

Attachment 50244: Patch
https://bugs.webkit.org/attachment.cgi?id=50244&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think you can get away with making a slider into a layout boundary. 
The thumb can visually overflow the bounds of the slider itself, unlike text
controls, which are guaranteed to clip their contents.	In order for a slider
to truly function as a layout root, it would have to clip the thumb.  The hacks
to prevent size changes by querying layout root seem bogus to me as well.


More information about the webkit-reviews mailing list