[webkit-reviews] review granted: [Bug 37917] Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:] : [Attachment 53942] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 37917: Many crashes in Safari inside Flip4Mac below -[NSAlert
didEndAlert:returnCode:contextInfo:]
https://bugs.webkit.org/show_bug.cgi?id=37917

Attachment 53942: Patch
https://bugs.webkit.org/attachment.cgi?id=53942&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. 
We sizzle the TSUpdateCheck methods
> first since it is possible that in some versions of Flip4Mac the
TSUpdateCheck class may not exist or may not have
> the method we're interested in.  In that case we want to bail out before
patching the NSAlert method.

Minor nit - "We sizzle the TSUpdateCheck methods first" makes it sound like you
might patch TSUpdateCheck but not patch alertDidEnd:returnCode:contextInfo:,
which isn't true.

I have attached a wmv file you can use for a manual test if you want.

Nice fix!

r=me